Fixed problems with string init of array #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Jenkins rerun this test please |
1 similar comment
Contributor
|
Jenkins rerun this test please |
Contributor
|
Retest this please Jenkins. "Fips Check" history unavailable. This looks to solve a "make check" failure with wolfCLU. Is it ready for review? |
gcc throws a warning when an array is initialized with a string of equal size that has explicit null terminators. To fix this I just removed trailing null terminators on the string since they will be inserted by C conforming compilers anyway.
sebastian-carpenter
force-pushed
the
buffer-init-with-string
branch
from
a267043 to
74a30c3
Compare
JacobBarthelmeh
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some arrays have strings used to initialize them with explicit null terminators as padding. This padding method causes gcc to throw warnings so I removed it. Conforming C compilers should automatically fill the rest of the array slots with null terminators.
my compiler info:
gcc version 15.1.1 20250425 (Red Hat 15.1.1-1) (GCC)